Add abstract class for migrations

Signed-off-by: Daniel Kesselberg <[email protected]>
jhass · Feb 23, 2020 · 6742d2f · 6742d2f
1 parent e1d8e1c
commit 6742d2f
Show file tree

Hide file tree

Showing 3 changed files with 35 additions and 30 deletions.
diff --git a/keeweb/lib/Migration/MimeTypeMigration.php b/keeweb/lib/Migration/MimeTypeMigration.php
@@ -0,0 +1,19 @@
+<?php
+
+namespace OCA\Keeweb\Migration;
+
+use OCP\Files\IMimeTypeLoader;
+use OCP\Migration\IOutput;
+use OCP\Migration\IRepairStep;
+
+abstract class MimeTypeMigration implements IRepairStep
+{
+    const CUSTOM_MIMETYPEMAPPING = 'mimetypemapping.json';
+
+    protected $mimeTypeLoader;
+
+    public function __construct(IMimeTypeLoader $mimeTypeLoader)
+    {
+        $this->mimeTypeLoader = $mimeTypeLoader;
+    }
+}
diff --git a/keeweb/lib/Migration/RegisterMimeType.php b/keeweb/lib/Migration/RegisterMimeType.php
@@ -6,30 +6,23 @@
 use OCP\Migration\IOutput;
 use OCP\Migration\IRepairStep;
 
-class RegisterMimeType implements IRepairStep
+class RegisterMimeType extends MimeTypeMigration
 {
-    private $mimeTypeLoader;
-
-    public function __construct(IMimeTypeLoader $mimeTypeLoader)
-    {
-        $this->mimeTypeLoader = $mimeTypeLoader;
-    }
-
     public function getName()
     {
         return 'Register MIME type for "application/x-kdbx"';
     }
 
     private function registerForExistingFiles()
     {
-        $mimetypeId = $this->mimeTypeLoader->getId('application/x-kdbx');
-        $this->mimeTypeLoader->updateFilecache('kdbx', $mimetypeId);
+        $mimeTypeId = $this->mimeTypeLoader->getId('application/x-kdbx');
+        $this->mimeTypeLoader->updateFilecache('kdbx', $mimeTypeId);
     }
 
     private function registerForNewFiles()
     {
         $mapping = ['kdbx' => ['application/x-kdbx']];
-        $mappingFile = \OC::$configDir . 'mimetypemapping.json';
+        $mappingFile = \OC::$configDir . self::CUSTOM_MIMETYPEMAPPING;
 
         if (file_exists($mappingFile)) {
             $existingMapping = json_decode(file_get_contents($mappingFile), true);
@@ -43,14 +36,14 @@ private function registerForNewFiles()
 
     public function run(IOutput $output)
     {
-        $this->logger->info('Registering the mimetype...');
+        $output->info('Registering the mimetype...');
 
         // Register the mime type for existing files
         $this->registerForExistingFiles();
 
         // Register the mime type for new files
         $this->registerForNewFiles();
 
-        $this->logger->info('The mimetype was successfully registered.');
+        $output->info('The mimetype was successfully registered.');
     }
 }
diff --git a/keeweb/lib/Migration/UnregisterMimeType.php b/keeweb/lib/Migration/UnregisterMimeType.php
@@ -6,29 +6,22 @@
 use OCP\Migration\IOutput;
 use OCP\Migration\IRepairStep;
 
-class UnregisterMimeType implements IRepairStep
+class UnregisterMimeType extends MimeTypeMigration
 {
-    private $mimeTypeLoader;
-
-    public function __construct(IMimeTypeLoader $mimeTypeLoader)
-    {
-        $this->mimeTypeLoader = $mimeTypeLoader;
-    }
-
     public function getName()
     {
         return 'Unregister MIME type for "application/x-kdbx"';
     }
 
-    private function registerForExistingFiles()
+    private function unregisterForExistingFiles()
     {
-        $mimetypeId = $this->mimeTypeLoader->getId('application/octet-stream');
-        $this->mimeTypeLoader->updateFilecache('kdbx', $mimetypeId);
+        $mimeTypeId = $this->mimeTypeLoader->getId('application/octet-stream');
+        $this->mimeTypeLoader->updateFilecache('kdbx', $mimeTypeId);
     }
 
-    private function registerForNewFiles()
+    private function unregisterForNewFiles()
     {
-        $mappingFile = \OC::$configDir . 'mimetypemapping.json';
+        $mappingFile = \OC::$configDir . self::CUSTOM_MIMETYPEMAPPING;
 
         if (file_exists($mappingFile)) {
             $mapping = json_decode(file_get_contents($mappingFile), true);
@@ -43,14 +36,14 @@ private function registerForNewFiles()
 
     public function run(IOutput $output)
     {
-        $this->logger->info('Unregistering the mimetype...');
+        $output->info('Unregistering the mimetype...');
 
         // Register the mime type for existing files
-        $this->registerForExistingFiles();
+        $this->unregisterForExistingFiles();
 
         // Register the mime type for new files
-        $this->registerForNewFiles();
+        $this->unregisterForNewFiles();
 
-        $this->logger->info('The mimetype was successfully unregistered.');
+        $output->info('The mimetype was successfully unregistered.');
     }
 }