Fix console errors (airbytehq#17696)

jhammarstedt · Oct 31, 2022 · 8587e94 · 8587e94
1 parent 4e8cbac
commit 8587e94
Show file tree

Hide file tree

Showing 7 changed files with 33 additions and 38 deletions.
diff --git a/airbyte-webapp/package-lock.json b/airbyte-webapp/package-lock.json
diff --git a/airbyte-webapp/package.json b/airbyte-webapp/package.json
@@ -47,7 +47,7 @@
     "query-string": "^6.13.1",
     "react": "^17.0.2",
     "react-dom": "^17.0.2",
-    "react-helmet": "6.1.0",
+    "react-helmet-async": "^1.3.0",
     "react-intl": "^6.1.1",
     "react-lazylog": "^4.5.3",
     "react-markdown": "^7.0.1",

diff --git a/airbyte-webapp/src/App.tsx b/airbyte-webapp/src/App.tsx
@@ -1,4 +1,5 @@
 import React, { Suspense } from "react";
+import { HelmetProvider } from "react-helmet-async";
 import { BrowserRouter as Router } from "react-router-dom";
 import { ThemeProvider } from "styled-components";
 
@@ -47,7 +48,9 @@ const Services: React.FC<React.PropsWithChildren<unknown>> = ({ children }) => (
             <ConfirmationModalService>
               <ModalServiceProvider>
                 <FormChangeTrackerService>
-                  <ApiServices>{children}</ApiServices>
+                  <HelmetProvider>
+                    <ApiServices>{children}</ApiServices>
+                  </HelmetProvider>
                 </FormChangeTrackerService>
               </ModalServiceProvider>
             </ConfirmationModalService>

diff --git a/airbyte-webapp/src/components/HeadTitle/HeadTitle.tsx b/airbyte-webapp/src/components/HeadTitle/HeadTitle.tsx
@@ -1,5 +1,5 @@
 import React from "react";
-import { Helmet } from "react-helmet";
+import { Helmet } from "react-helmet-async";
 import { useIntl } from "react-intl";
 
 const AIRBYTE = "Airbyte";

diff --git a/airbyte-webapp/src/components/icons/CreditsIcon.tsx b/airbyte-webapp/src/components/icons/CreditsIcon.tsx
@@ -11,8 +11,8 @@ export const CreditsIcon = ({ color = theme.greyColor20 }: Props) => (
       fill="white"
     />
     <path
-      fill-rule="evenodd"
-      clip-rule="evenodd"
+      fillRule="evenodd"
+      clipRule="evenodd"
       d="M10.9338 10.8869C11.8855 9.81015 13.4616 9.49428 14.7573 10.1158C16.4788 10.9417 17.1068 13.0455 16.1696 14.6684L14.0611 18.3151C13.9433 18.5189 13.7494 18.6675 13.522 18.7285C13.2946 18.7894 13.0524 18.7576 12.8484 18.6401L15.4011 14.2243C16.0811 13.0464 15.6263 11.5197 14.3782 10.9186C13.4417 10.4676 12.2969 10.6929 11.6051 11.4685C11.2235 11.8943 11.0092 12.4441 11.0021 13.0158C10.9949 13.5875 11.1954 14.1425 11.5662 14.5777C11.6329 14.6558 11.7046 14.7294 11.7809 14.7981L10.2907 17.3806C10.2324 17.4816 10.1548 17.5701 10.0623 17.641C9.96985 17.712 9.8643 17.7641 9.7517 17.7942C9.6391 17.8244 9.52166 17.8321 9.40609 17.8169C9.29051 17.8017 9.17906 17.7639 9.0781 17.7056L10.6959 14.9019C10.4635 14.5669 10.2967 14.1909 10.2041 13.7938L9.2127 15.5153C9.09485 15.7191 8.90096 15.8678 8.67359 15.9287C8.44622 15.9897 8.20396 15.9579 8 15.8404L10.5637 11.3997C10.6704 11.2174 10.7944 11.0456 10.9338 10.8869ZM13.8928 12.3004C14.5103 12.657 14.7235 13.45 14.3662 14.0671L11.9078 18.3145C11.79 18.5183 11.5961 18.667 11.3687 18.7279C11.1413 18.7889 10.8991 18.7571 10.6951 18.6396L12.9778 14.6852C12.7947 14.6466 12.6221 14.5688 12.4719 14.457C12.3218 14.3453 12.1977 14.2023 12.1082 14.0379C12.0187 13.8735 11.966 13.6916 11.9536 13.5049C11.9413 13.3181 11.9696 13.1309 12.0366 12.9561C12.1037 12.7814 12.2078 12.6233 12.342 12.4927C12.4761 12.3621 12.6369 12.2622 12.8134 12.1999C12.9899 12.1375 13.1778 12.1142 13.3641 12.1316C13.5505 12.1489 13.7309 12.2065 13.8928 12.3004ZM12.9986 13.0986C12.9564 13.131 12.9209 13.1715 12.8943 13.2176H12.8942C12.8541 13.2871 12.8355 13.3669 12.8407 13.447C12.846 13.527 12.8748 13.6037 12.9237 13.6674C12.9725 13.731 13.0392 13.7787 13.1151 13.8045C13.1911 13.8303 13.273 13.833 13.3505 13.8122C13.428 13.7915 13.4976 13.7482 13.5505 13.6879C13.6034 13.6275 13.6372 13.5529 13.6477 13.4733C13.6581 13.3938 13.6448 13.3129 13.6093 13.241C13.5738 13.169 13.5178 13.1092 13.4483 13.0691C13.4022 13.0425 13.3513 13.0252 13.2985 13.0182C13.2457 13.0113 13.192 13.0148 13.1405 13.0286C13.0891 13.0424 13.0409 13.0662 12.9986 13.0986Z"
       fill="white"
     />

diff --git a/airbyte-webapp/src/components/ui/PageHeader/PageHeader.tsx b/airbyte-webapp/src/components/ui/PageHeader/PageHeader.tsx
@@ -20,7 +20,7 @@ export const PageHeader: React.FC<PageHeaderProps> = ({
   middleTitleBlock,
   endComponent,
 }) => (
-  <div className={classNames(styles.container)} data-withLine={withLine}>
+  <div className={classNames(styles.container)} data-withline={withLine}>
     <Text
       as="h1"
       size="md"

diff --git a/airbyte-webapp/src/packages/cloud/App.tsx b/airbyte-webapp/src/packages/cloud/App.tsx
@@ -1,5 +1,6 @@
 import GlobalStyle from "global-styles";
 import React, { Suspense } from "react";
+import { HelmetProvider } from "react-helmet-async";
 import { BrowserRouter as Router } from "react-router-dom";
 import { ThemeProvider } from "styled-components";
 
@@ -45,7 +46,9 @@ const Services: React.FC<React.PropsWithChildren<unknown>> = ({ children }) => (
               >
                 <AppServicesProvider>
                   <AuthenticationProvider>
-                    <IntercomProvider>{children}</IntercomProvider>
+                    <HelmetProvider>
+                      <IntercomProvider>{children}</IntercomProvider>
+                    </HelmetProvider>
                   </AuthenticationProvider>
                 </AppServicesProvider>
               </FeatureService>