Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.tag breaks WordPress #912

Closed
Log1x opened this issue Jul 25, 2017 · 1 comment · Fixed by #1092
Closed

.tag breaks WordPress #912

Log1x opened this issue Jul 25, 2017 · 1 comment · Fixed by #1092

Comments

@Log1x
Copy link
Contributor

Log1x commented Jul 25, 2017

Overview of the problem

This is about the Bulma CSS framework

I'm using Bulma version [0.4.4]

Description

I'm sure this issue will cause some face-palming (as it should)-- but I feel like it should be brought up.

When viewing a tag archive on WordPress, it adds tag into the body class. This causes the layout to break with Bulma.

This was also an issue on Bootstrap.

Their fix was to rename .tag to .badge-- but I think a more Bulma-like approach would be something like:

.tag:not(body)

I'd love a fix on this at a Bulma level, but if you're not interested in compatibility, there is WordPress-specific approaches such as modifying body_class filter to swap class names, but this is quite a messy fix for something that should be able to solved with minimal conflict and without changing .tag as a whole by utilizing :not.

Steps to Reproduce

  1. Use Bulma in your WordPress theme
  2. Visit site.com/tag/example
  3. Be sad.
@Log1x Log1x mentioned this issue Aug 19, 2017
jgthms pushed a commit that referenced this issue Aug 21, 2017
@LZDevs
Copy link

LZDevs commented Oct 9, 2024

The issue is there in v1.0.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants