Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change order of setFlag function #1326

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Change order of setFlag function #1326

merged 1 commit into from
Nov 19, 2024

Conversation

radiohound
Copy link
Contributor

The change allows the code to compile. The same issue exists with a few other examples too.

Pull request template

Thank you for taking the time to contribute to RadioLib development!
To keep this library organized, please follow these rules.

  1. Make sure the the code in your PR is tested and that you understand all its impacts.
  2. Ensure that all CI actions pass - PRs with failed CI will not be merged. CI actions run automatically for every commit pushed to the PR and test the following:
    a. Compilation for Arduino, ESP-IDF and on Raspberry Pi
    b. Runtime test on Raspberry Pi
    c. GitHub CodeQL check
    d. Cppcheck static code scan
  3. Follow code style guidelines in CONTRIBUTING.md
  4. Heads up - all PRs undergo review, during which you may be asked to correct or change some things. The purpose of this review is to keep regressions and bugs at the minimum, and to keep consistent coding style. Please take them as constructive criticism from people who may have a different point-of-view than you do.

After addressing/accepting the points above, delete the contents of this template and replace it with text explaining what is the goal of your PR, why you want to add it to the upstream and what are the foreseen impacts. Once again, thank you for taking the time to contribute!

The change allows the code to compile. The same issue exists with a few other examples too.
@jgromes
Copy link
Owner

jgromes commented Nov 19, 2024

Good catch - thank you for the contribution! I'm guessing this slipped by our CI because:

  1. We are using arduino-cli to build all the examples in the CI.
  2. Arduino automatically generates prototypes of all functions in the .ino file, which makes them order-independent. Since you use platformio (as reported in Trying to convert the APRS_Position_LoRa.ino example to STM32WL for Ebyte's E77 STM32WLE5CCU6 board #1323), this became a problem.

I will go through the other examples to make sure this is fixed everywhere.

@jgromes jgromes merged commit b3efc84 into jgromes:master Nov 19, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants