-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LoRaWAN] Major rework #1204
[LoRaWAN] Major rework #1204
Conversation
Is this required by some corner case on the spec - because it's the simplest way to DDOS a gateway - have all your nodes set to uplink at the top of the hour ... It also contradicts TR007 with jitter - randomisation of uplink time - I usually use ±60 seconds for deployment. Making the function inconspicuous is fine. |
It's not in TS001, it is in another TS.. but I can surely make it private. |
Edited original post to reflect additional change. |
…-band frequencies
@jgromes all done (plus minor edit of original post) |
Merged - great job @StevenCellist! I ran the full CI manually and it still fails in couple of places, but that's unrelated to this PR, so I will fix it later. |
Woohoo! 🎉 |
@jgromes best of luck... :)
Culmination of a whole summer of development.
Totally non-exhaustive list of changes in somewhat random order of importance:
uplink()
anddownlink()
as this separation is not possible with ADR and LBTPhysicalLayer::setModem()
to be implemented before completely workingAdditional changes:
NO_DOWNLINK
orERR_NONE
- this is a 'breaking' change.getMaxPayloadLen()
for non-dwell-time bands for ease of use under ADR.