[PHY, modules, LoRaWAN] Generalize IRQ checks #1188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgromes
requested changes
Aug 17, 2024
jgromes
approved these changes
Aug 18, 2024
|
All looks good now - merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using a specific
isRxTimeout()function, this PR adds a general functionisIrqSet()for most common IRQ values on a range of modules (SX126x, SX127x, SX128x and LR11x0). This makes it easy to retrieve low-level IRQ status flags while retaining the radio abstraction. I am not sure if / how to implement this for other classes; they seem to work in a different way.As the LoRaWAN stack used the function
isRxTimeout(), it has been modified accordingly and is checked to run as usual.