[LoRaWAN] To change CR to 4/5 for all frequency plans #1115
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team,
I'm testing RadioLib in AS923 frequency plan.
I realize RadioLib uses CR 4/7 for AS923 and other Asian frequency plans such as CN, AS923, EU433, KR and IN.
I read the LoRaWAN regional parameter. It never mentions which CR to use for CN, AS923, EU433, KR and IN
https://resources.lora-alliance.org/technical-specifications/rp002-1-0-4-regional-parameters
However, the default CR in use for LoRaWAN server and gateways and devices is CR 4/5 for AS923_1/2/3/4.
This is CR 4/5 in ChirpStack LoRaWAN Server in AS923. All frequency plans use CR 4/5.
https://github.com/chirpstack/chirpstack/blob/master/lrwn/src/region/as923.rs#L45
The Things Stack also uses CR 4/5 for AS923.
https://github.com/TheThingsNetwork/lorawan-stack/blob/v3.31/pkg/band/as_923_rp2_v1_0_4.go#L106
All Dragino devices and RAK 3172 Evaluation Board use CR 4/5 for AS923.
In CR 4/7, gateways receives the packets but ChirpStack seems to drop the packets.
After changing to CR 4/5, everything works perfect.
I fix to all frequency plans to use CR 4/5 too.
Thanks a lot.