-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes overload warning when building with ESP IDF #1089
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for this contribution! Could you also add doxygen comments to the .h files, similar to what was done for
|
Sure! Leave it with me
Best Regards
Kind Regards
Dominic Moffat
Electronic Design Director
Illysky Ltd
1 Field Rise, Ticehurst, East Sussex, TN5 7FH
+44 (0) 7732 885 372
This email and any files transmitted with it are confidential and intended
solely for the individual to whom it is addressed. Any views or opinions
presented are those of the author and do not necessarily represent those of
Illysky Ltd
…On Wed, 8 May 2024 at 09:46, Jan Gromeš ***@***.***> wrote:
Thank you for this contribution! Could you also add doxygen comments to
the .h files, similar to what was done for getRSSI?
/*!
\brief Gets recorded signal strength indicator.
Overload with packet mode enabled for PhysicalLayer compatibility.
\returns RSSI value in dBm.
*/
float getRSSI();
—
Reply to this email directly, view it on GitHub
<#1089 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADZXPCXSVNN6O7D6XSGWMWDZBHQ4XAVCNFSM6AAAAABHMO2YV6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBQGA3TCNZWGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Since this has been left open for a while, I'm going to merge this as-is and add the doxygen comments afterwards. Thanks for the contribution! |
Hello! Apologies, few really busy weeks with work, thank you. If you need
anything else please let me know.
Kind Regards
Dominic Moffat
Electronic Design Director
Illysky Ltd
1 Field Rise, Ticehurst, East Sussex, TN5 7FH
+44 (0) 7732 885 372
This email and any files transmitted with it are confidential and intended
solely for the individual to whom it is addressed. Any views or opinions
presented are those of the author and do not necessarily represent those of
Illysky Ltd
…On Wed, 15 May 2024 at 17:40, Jan Gromeš ***@***.***> wrote:
Since this has been left open for a while, I'm going to merge this as-is
and add the doxygen comments afterwards.
Thanks for the contribution!
—
Reply to this email directly, view it on GitHub
<#1089 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADZXPCS5VDKUT7Y4NQMHEILZCOFYDAVCNFSM6AAAAABHMO2YV6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJTGAYDIMRQGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
jgromes
added a commit
that referenced
this pull request
May 15, 2024
@illysky no worries, just something I wanted to scratch off the TODO list ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to previous fixes on overload on getRSSI - a fix was also needed on some of the sleep functions.
Those were added.