-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated board definitions for the LoRaWAN Examples #1052
Conversation
Clarify intended purpose. Remove unsupported modules.
Added HelTec boards and corrected some errors
Added HelTec boards and corrected some errors
Added HelTec boards and corrected some errors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution! I left some comments, some things are not totally clear to me.
I glanced over the recent pin contributions but I haven't figured out why the Arduino IDE uses the #define board names that it does beyond the perils of having the Heltec BSP installed or not. Or indeed why there are variants of some boards defined that don't appear to exist in real life or how we've ended up with a set of pins added but the pragma says they aren't and how the WiFi board with LoRa on it has different pins from the board that doesn't have WiFi in it's name is beyond me. The other pragma description needs reviewing as well:
For instance the Heltec LoRa32 V3 that we use as the primary SX1262 test appears as I'll revisit the recent changes and XRef them against the vendor supplied schematics & https://github.com/lnlp/pinout-diagrams who created LMIC-node with all its setup / configs for different boards. I've got most of the boards so I can do a real-life check as well, I'll come back with further observations by end of Friday. |
@Velocet, as we've only just stabilised LoRaWAN and I can't see how it fits in to your home automation plans, would it be better to make RadioLib a dependency on your wrapper rather than fork the code? |
@HeadBoffin Let me try to enlighten you! xD The "official" short board name for the V3 is -DARDUINO_HELTEC_WIFI_LORA_32_V2 // ALL CAPS
-DARDUINO_BOARD="HELTEC_WIFI_LORA_32_V2" // ALL CAPS
-DARDUINO_VARIANT="heltec_wifi_lora_32_V2" // FolDer namE (watch out for the V2 at the end!) The mentioned I only forked RadioLib so i can test more easily and maybe make some contributions as i get along. In the end it will just be a protocol addition. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cross checked again with official definitions. No errors found.
I can't remove the readme from the PR?
Which ones? |
Well, then re-upload it! |
Will do so when i'm back home. Thanks for the hint. Seems the app doesn't let me do it. |
Another interesting issue regarding board definitions: espressif/arduino-esp32#9423 |
Like standing on quick sand some days! |
Finally readded the README.md. Now everything should be resolved. |
@Velocet looks good now, merged - thanks! However, with the caveat that I am not sure if these configuration files and pinmaps will remain long-term. So far it seems more trouble than it's worth (it is prone to breaking if the platform provider makes a brekign change and the CI for it is a nightmare). Guess we'll see ... |
I'm still wondering why you get all-capitalized defines an I don't... I double-checked my setup - it's all up-to-date. |
I see all caps for both Arduino and PlatformIO. |
Since i don't trust HelTec to get their board configurations right (or up-to-date) i used Arduino core for the ESP32 variants as source.