Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Fix for new LoraWAN examples #1035

Merged
merged 7 commits into from
Mar 26, 2024
Merged

[CI] Fix for new LoraWAN examples #1035

merged 7 commits into from
Mar 26, 2024

Conversation

jgromes
Copy link
Owner

@jgromes jgromes commented Mar 25, 2024

Added support for new LoRaWAN examples in CI. It now builds as can be seen e.g. here: https://github.com/jgromes/RadioLib/actions/runs/8425458582/job/23071608049

All config.h-defined RADIOLIB_LORAWAN_* macros are set to 0 during build in CI.

Heads up - I had to do two small changes in the config.h files:

  1. Uncomment SX127x in case pinout detection fails, so that radio is not undefined in CI - I guess the intention there was to force the user to select a module/pinout appropriate for them. But defining this from CI would require additional ifdefs, I don't think it's wort the extra trouble.
  2. Change the arrayDump so that it doesn't use HardwareSerial::printf which may or may not be available

I think both of these are quite minor, @StevenCellist and/or @HeadBoffin please let me know if those changes are OK; asking since the first one slightly changes the default behavior of the example.

@StevenCellist
Copy link
Collaborator

I suggest acting as if a board was defined, e.g. a Heltec or LilyGo board.
E.g. -D ARDUINO_heltec_wifi_kit_32_V3

@HeadBoffin
Copy link
Collaborator

All good, having CI run is important - we can flag a radio not initialised error in conjunction with the "pinmap 101". The arrayDump isn't called from any examples at this point, I typically use it to run the firmware without the radio and then copy & paste the printed payload in to a spreadsheet that can verify the payload, or the console payload formatter or in to the back end etc etc. I guess it could actually be removed for now if considered redundant.

@HeadBoffin
Copy link
Collaborator

I suggest acting as if a board was defined, e.g. a Heltec or LilyGo board. E.g. -D ARDUINO_heltec_wifi_kit_32_V3

"Bloody hell," said Majikthise, "now that is what I call thinking. Here Vroomfondel, why do we never think of things like that?" - "Dunno," said Vroomfondel in an awed whisper, "think our brains must be too highly trained Majikthise."

@jgromes
Copy link
Owner Author

jgromes commented Mar 25, 2024

@StevenCellist did it as suggested. I will wait for the manual CI run to complete and then merge.

@HeadBoffin

The arrayDump isn't called from any examples at this point

True, but if it's in there it neeeds to compile - and ESP GCC really didn't like that unitialized variable (because of its -Werror flag): https://github.com/jgromes/RadioLib/actions/runs/8424942406/job/23069963065

@jgromes jgromes merged commit 9e4783c into master Mar 26, 2024
57 checks passed
@jgromes jgromes deleted the lorawan_ci branch March 26, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants