LW examples #1034
Merged
LW examples #1034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LoRaWAN examples update
|
@HeadBoffin @jgromes looks all good to me. |
jgromes
approved these changes
Mar 25, 2024
|
That wasn't a nice squashed merge, oops, sorry, but it's in :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just the Starter, ABP and Reference.
There is a winkle with ABP nomclementure & the order of parameters between the TTN console and beginABP. The config.h matches the Overview on console but the parameter names don't currently match under the hood. This will only be spotted by someone looking at the code before @StevenCellist corrects it.
There is also the possibility that we can drop the force=true on beginOTAA if there is no session restored from persistence.
Despite the above, this moves things forward and more importantly, some actual proper device testing can be done on other platforms (AVR, SAMD, STM32) and, for the other repro, persistence as well as working on the wiki.
Feel free to enact any changes to get these over the wire please.