Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radiolib fails to build with -DRADIOLIB_EXCLUDE_SX1231 #929

Closed
jp-bennett opened this issue Jan 14, 2024 · 1 comment
Closed

Radiolib fails to build with -DRADIOLIB_EXCLUDE_SX1231 #929

jp-bennett opened this issue Jan 14, 2024 · 1 comment
Labels
bug Something isn't working resolved Issue was resolved (e.g. bug fixed, or feature implemented)

Comments

@jp-bennett
Copy link
Contributor

Troubleshooting build failures with Meshtastic and RadioLib 6.4.0. At my initial look, it seems like RadioLib fails to build when -DRADIOLIB_EXCLUDE_SX1231 is set.

                 from src/mesh/RadioLibInterface.h:7,
                 from src/mesh/SX126xInterface.h:3,
                 from src/mesh/LLCC68Interface.h:3,
                 from src/main.cpp:57:
.pio/libdeps/rak11200/RadioLib/src/modules/SX123x/SX1233.h:23:30: error: expected class-name before '{' token
 class SX1233: public SX1231  {
                              ^```
@jgromes
Copy link
Owner

jgromes commented Jan 14, 2024

@jp-bennett thanks for reporting! I pushed a fix; if you want to stick weith the 6.4.0 release, you should be able to use -DRADIOLIB_EXCLUDE_SX1233 together with -DRADIOLIB_EXCLUDE_SX1231 as a workaround.

@jgromes jgromes closed this as completed Jan 14, 2024
@jgromes jgromes added bug Something isn't working resolved Issue was resolved (e.g. bug fixed, or feature implemented) labels Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working resolved Issue was resolved (e.g. bug fixed, or feature implemented)
Projects
None yet
Development

No branches or pull requests

2 participants