Wrap all custom jq filters in implicit '()' #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrapped all custom jq filter expressions provided by the user's configuration in `(...)`. Prior to this, if the user's expression included a pipe `|` operator, it would break the filter join. The workaround would force the user to wrap all of his expressions in a `(...)` in his resource config, which is a little verbose and repetitive (not to mention annoying). Now, it's handled automatically. This doesn't cause any problems if the user also provides his own `(...)` wrapping, so this is a backwards compatible "fix". Also polished the README section discussing the jq filter. It was a bit confusing, and had a few spelling and grammar errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrapped all custom jq filter expressions provided by the user's
configuration in
(...). Prior to this, if the user's expressionincluded a pipe
|operator, it would break the filter join.The workaround would force the user to wrap all of his
expressions in a
(...)in his resource config, which is a littleverbose and repetitive (not to mention annoying).
Now, it's handled automatically. This doesn't cause any problems if the
user also provides his own
(...)wrapping, so this is abackwards compatible "fix".
Also polished the README section discussing the jq filter. It was a
bit confusing, and had a few spelling and grammar errors.