Added Pinned pkgs info #103
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e.g: pywin32==306 is available (you have 304) [Pinned] tornado==6.3.2 is available (you have 6.1) Tested only on Windows
jgonggrijp
requested changes
Jun 16, 2023
There was a problem hiding this comment.
Great suggestion, thanks!
I want to merge this, but I have three requests:
- Please add a test so that the feature can be verified in CI. I think this feature is doable with the existing
cramtest setup. - Please use the word "constrained" instead of "pinned". This makes it less ambiguous with "pinned dependencies" in a
requirements.txt. - Please make it clear in the output which version is listed in the constraints file. If it is guaranteed to be equal to the installed version, I suggest
pywin32==306 is available (you have 304, constrained). Otherwise, I suggestpywin32==306 is available (you have 304) [Constrained to 304].
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e.g:
pywin32==306 is available (you have 304) [Pinned]
tornado==6.3.2 is available (you have 6.1)
Tested only on Windows