Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for undefined method 'map' for nil #66

Merged
merged 4 commits into from
Jan 29, 2023
Merged

Fix for undefined method 'map' for nil #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
694778a
[fix] line_item nil check
ewan-jrpets Oct 31, 2022
7330a54
Revert "[fix] line_item nil check"
ewan-jrpets Dec 5, 2022
39c6274
[fix] Moved nil guard based on feedback
ewan-jrpets Dec 5, 2022
c613563
[fix] Accidental reference to wrong variable
ewan-jrpets Dec 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ruby_scripts/common/campaign.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,10 @@ def qualifies?(cart)
end rescue nil
if is_selector
raise "Missing line item match type" if @li_match_type.nil?
cart.line_items.send(@li_match_type) { |item| qualifier.match?(item) }
cart.line_items.send(@li_match_type) do |item|
next false if item.nil?
qualifier.match?(item)
end
else
qualifier.match?(cart, @line_item_selector)
end
Expand Down
5 changes: 4 additions & 1 deletion src/scripts/common.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,10 @@ class Campaign
end rescue nil
if is_selector
raise "Missing line item match type" if @li_match_type.nil?
cart.line_items.send(@li_match_type) { |item| qualifier.match?(item) }
cart.line_items.send(@li_match_type) do |item|
next false if item.nil?
qualifier.match?(item)
end
else
qualifier.match?(cart, @line_item_selector)
end
Expand Down