Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HTML] Highlighted inline code within strikeout is not applied correctly #79

Closed
mpark opened this issue Jun 14, 2019 · 2 comments · Fixed by #80
Closed

[HTML] Highlighted inline code within strikeout is not applied correctly #79

mpark opened this issue Jun 14, 2019 · 2 comments · Fixed by #80

Comments

@mpark
Copy link

mpark commented Jun 14, 2019

Consider: ~~foo `constexpr`{.cpp} bar~~
With pandoc foo.md --output foo.html --self-contained this currently generates:
Screen Shot 2019-06-13 at 10 46 58 PM

The desired output would be something like:
Screen Shot 2019-06-13 at 10 47 19 PM


This seems to be caused by the display: inline-block from

"code.sourceCode > span { display: inline-block; line-height: 1.25; }"
.
Changing this to display: inline produces the desired output.

@jgm
Copy link
Owner

jgm commented Jun 14, 2019

@dbaynard may be able to say more than I can about why display: block is in there...

mpark added a commit to mpark/wg21 that referenced this issue Jun 14, 2019
@dbaynard
Copy link
Contributor

dbaynard commented Jun 14, 2019

This is a bug, introduced in 0b07bbc when the line span tags were simplified — I didn't notice the clash.

<code class="sourceCode cpp"><span class="kw">constexpr</span></code>

This is treating the span as a line. The css should probably restrict that behaviour to pre > code.sourceCode > span. I'm making the PR, now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants