Fixes and Enhancements from the tracker #1644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the internal representation to fix the problem. I haven't tested this on windows. Closes jgm#1597
|
Excellent! I made a couple line comments in the katex commit. |
|
Do you want me to make any changes to these patches? I just added another fix. |
jgm
added a commit
that referenced
this pull request
Sep 27, 2014
Fixes and Enhancements from the tracker
|
I still think maybe we should default to https for both katex and mathjax (assuming it's available), but I'm not sure. |
|
I made an uninformed choice to use |
|
MathJax finally added https protocol support to their official CDN (previously it was at a separate address) as of a few months ago, so it would be a timely change. |
|
Windows VM test gives one failure. See screenshot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits for more a more fine-grained summary.
Closes #1620 #1625 #1626 #1635 and #1597