Prefer MIME type when determining extensions for MediaBag items #10557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, remote images added to the MediaBag are stored at paths with extensions determined based on the external URI. For instance, an image from https://example.com/image.png is stored as <hash>.png. If the URI does not contain an extension (e.g., https://example.com/image), then the content-type of the downloaded image is used to determine the extension. This change switches the precedence such that content-type is preferred over extensions contained in the URI. This is necessary because some images are located at URIs with misleading extensions -- shields.io, for instance, serves SVGs from URIs with .yml extensions. With this change, the image/svg+xml content-type is now preferred over the .yml URI extension. This fixes a bug in the PDF writer in which such an image would be mishandled due to not being identified as an SVG.
max-heller
force-pushed
the
mediaitem-extensions
branch
from
511fcb9 to
6866b43
Compare
|
thanks! |
max-heller
added a commit
to max-heller/mdbook-pandoc
that referenced
this pull request
Feb 9, 2025
Removes a workaround for remote images served from URIs without standard image extensions (e.g., https://img.shields.io/github/actions/workflow/status/rust-lang/mdBook/main.yml hosts an SVG image despite its YAML extension) since Pandoc implemented a fix in jgm/pandoc#10557 (released in 3.6.3). This allows removing the dependency on an HTTP client.
max-heller
added a commit
to max-heller/mdbook-pandoc
that referenced
this pull request
Feb 9, 2025
Removes a workaround for remote images served from URIs without standard image extensions (e.g., https://img.shields.io/github/actions/workflow/status/rust-lang/mdBook/main.yml hosts an SVG image despite its YAML extension) since Pandoc implemented a fix in jgm/pandoc#10557 (released in 3.6.3). This allows removing the dependency on an HTTP client.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, remote images added to the MediaBag are stored at paths with extensions determined based on the external URI. For instance, an image from https://example.com/image.png is stored as .png. If the URI does not contain an extension (e.g., https://example.com/image), then the content-type of the downloaded image is used to determine the extension.
This change switches the precedence such that content-type is preferred over extensions contained in the URI. This is necessary because some images are located at URIs with misleading extensions -- shields.io, for instance, serves SVGs from URIs with .yml extensions. With this change, the image/svg+xml content-type is now preferred over the .yml URI extension. This fixes a bug in the PDF writer in which such an image would be mishandled due to not being identified as an SVG.
Closes #10553