-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JATS permission/copyright metadata absent from pandoc metadata #8867
Comments
@castedo This is because there is no provision in the JATS reader to parse the contents of the
|
Nice, definitely an improvement! However, it falls slightly short of a feature level we could call "JATS4R level 42" for lack of a better name (or another name, as long as it is funny 😃). It is based on the JATS4R that I've been archiving in baseprints like this one: Some more examples of JATS4R license XML are here: I'll propose more details on JATS4R level 42 functionality here soon (like within an hour). |
Here is some YAML that is of interest:
This is the YAML that I currently use with pandoc to produce JATS4R XML. I think this generates a native objective model that is more structured than the |
Another YAML detail:
That's the YAML I use to produce good JATS4R XML. It looks like the copyright needs to be a single object/key with three members/subkeys rather than three separate top-level objects/keys. |
I can propose that the first key behavior of JATS4R level 42 functionality is that this
I propose another second key behavior which is that the following XML conversion of jats-without-license_ref.xml.txt
generates
|
See #9034 - does this take care of it? |
Eyeballing the Haskell code it looks to me like not. copyright-statement copyright-year an copyright-holder are top-level and license is a single value, not a 3-part object. (I'm not sure whether I'm using sensible terms for Haskell) |
@kamoe It seems to me that making |
Regarding the JATS4R recommendation of
outputs panda.md. Furthermore, proper valid XML parsing means the following XML should produce the same result: jats-crazy.xml.txt |
One quick note: the panda.md used in the above examples is the minimal case using all the copyright and license metadata documented on https://pandoc.org/jats.html. So if XML namespaces are handled, then supporting all three proposed behaviors above is a very nice "JATS4R level 42" to achieve for pandoc. |
How about this output:
|
@kamoe LGTM (since pandoc converts it to yaml that matches pandoc.org/jats.html) Thanks! This is all data I'd like to use and I currently hard code it into HTML and PDF outputs rather than reading it from JATS XML. Now I'll be able to actually read it from JATS XML via pandoc! 👍 |
and by "I" I really should say the open-source library epijats (gitlab.com/perm.pub/epijats) 😬 |
Closed by #9037. |
Nice enhancement! I just tested changing |
I submit this issue because @kamoe was interested in seeing cases like this. This issue is one case of a more general issue #8359 (resolved as closed and out of scope in late 2022).
This applies to both PMC JATS, JATS4R and "pandoc JATS", that is, JATS generated by the default JATS template and documented as JATS that pandoc supports on https://pandoc.org/jats.html.
It is worth noting that this uses a JATS4R feature that depends on XML namespaces. Specifically the part with
This introduces complications of XML namespaces. For instance, I believe technically the
xmlns:ali=
attribute can be changed and then theali:
part can be dropped or renamed, and this should be parsed the same. This is the kind of thing a full XML parser will handle.Pandoc returns nothing in the pandoc metadata for this simple example of "pandoc JATS" input:
It is also worth noting there is an older dialect of JATS out there that is different from the license schema of the JATS4R dialect here. An example of such an older dialect is the JATS4R that eLife is still using for their public JATS XML they provide, but not their JATS XML which gets stored in PMC. So for the very same eLife article, there is a JATS XML file eLife provides publicly (from github and their website I believe) and there is a different flavor of JATS XML file stored in PMC ... for the very same article. One uses the JATS4R license schema above and the other dialect does something else.
The text was updated successfully, but these errors were encountered: