Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support toc-title in revealjs #7170

Closed
fkohrt opened this issue Mar 21, 2021 · 2 comments · Fixed by #7171
Closed

Support toc-title in revealjs #7170

fkohrt opened this issue Mar 21, 2021 · 2 comments · Fixed by #7171

Comments

@fkohrt
Copy link
Contributor

fkohrt commented Mar 21, 2021

Among other HTML formats, the HTML5 template includes the content of toc-title as heading:

$if(toc)$
<nav id="$idprefix$TOC" role="doc-toc">
$if(toc-title)$
<h2 id="$idprefix$toc-title">$toc-title$</h2>
$endif$
$table-of-contents$
</nav>
$endif$

Is there any reason against doing something similar for revealjs? Otherwise there's only an untitled slide containing the TOC, which doesn't look appealing.

@jgm
Copy link
Owner

jgm commented Mar 22, 2021

Yes I think we could do the same for revealjs. (If you want to submit a PR?)

@fkohrt
Copy link
Contributor Author

fkohrt commented Mar 22, 2021

Done. Wasn't sure about the heading level, but went for h2 as with html5. I also copied the nav, but in a separate commit in case you'd rather not have this in there.

@jgm jgm closed this as completed in #7171 Apr 30, 2021
jgm pushed a commit that referenced this issue Apr 30, 2021
* Support toc-title in revealjs
* Add semantic HTML "nav" tag

Closes #7170.

As with default.html5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants