Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolution of relative URIs in EPUB writer #1671

Closed
dgerber opened this issue Oct 8, 2014 · 0 comments
Closed

Resolution of relative URIs in EPUB writer #1671

dgerber opened this issue Oct 8, 2014 · 0 comments

Comments

@dgerber
Copy link

dgerber commented Oct 8, 2014

relativeTo in the Network.URI module should work better than simple string concatenation. There are quite a few differences with joining file paths.

One example:

pandoc http://www.acrimed.org/article4464.html -o /tmp/article.epub
pandoc: Could not find media `http://www.acrimed.org/article4464.html/IMG/arton3686.jpg?1412011455', skipping...

In the source html is <img src="IMG/arton3686.jpg?1412011455"> which should resolve to http://www.acrimed.org/IMG/arton3686.jpg?1412011455

From #1669.
@jgm jgm closed this as completed in f8087b6 Oct 8, 2014
jgm added a commit that referenced this issue Oct 8, 2014
@jgm
EPUB reader: Further URI handling improvements.
2eaa0f6 
Now we outsource most of the work to `fetchItem'`.
Also, do not include queries in file extensions.

Improves fix to #1671.

It is possible that this will have some unexpected effects, so
further testing would be good.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dgerber