Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipe table and table caption support (witiko/markdown backport) #39

Merged
merged 2 commits into from
Aug 11, 2022

Conversation

Omikhleia
Copy link
Contributor

This PR is the backport to lunamark of Vít Novotný's pipe table support from the witiko/markdown project.
(https://github.com/Witiko/markdown)

Note: witiko/markdown is now LPPL-licensed, but these improvements were added when the project was still MIT-licensed.

See #31 for context.

I also added support for these to the HTML writer, so that to provide a non-regression test case. The HTML output mimics that from Pandoc in terms of output, class and styles.

@Omikhleia Omikhleia force-pushed the backport_pipetable_witiko branch from be21ea3 to 680e2d7 Compare August 7, 2022 22:51
@Witiko
Copy link
Collaborator

Witiko commented Aug 7, 2022

Nice work. I glanced over the changes and here is a minor nitpick: the extension is called pipe_table and claims to be named the same as Pandoc's extension for pipe tables. However, Pandoc's extension for pipe tables is called pipe_tables (plural).

@Omikhleia
Copy link
Contributor Author

Omikhleia commented Aug 7, 2022

Nice work.

Thanks, although all credits are yours, it's quite a straightforward back-port ;)

However, Pandoc's extension for pipe tables is called pipe_tables (plural).

Oops, that's right. Shouldn't we follow the same name as in Pandoc, just for homogeneity? I.e. change it to pipe_tables?

(N.B. I'm leaving for vacations in the countryside tomorrow, not sure how network connectivity will be there... There's no urge, though!)

@Witiko
Copy link
Collaborator

Witiko commented Aug 8, 2022

Shouldn't we follow the same name as in Pandoc, just for homogeneity? I.e. change it to pipe_tables?

That's what I would do, but it's a minor complaint. Let me know when the PR is ready, so that I can do a proper review. Enjoy your vacation!

This is the backport to lunamark of Vít Novotný's pipe table
support from the witiko/markdown project.
(https://github.com/Witiko/markdown)

Note: witiko/markdown is now LPPL-licensed, but these improvements
were added when the project was still MIT-licensed.
@Omikhleia Omikhleia force-pushed the backport_pipetable_witiko branch from 680e2d7 to 7ab461d Compare August 11, 2022 10:08
@Omikhleia
Copy link
Contributor Author

Changed pipe_table option to pipe_tables

@Witiko Witiko merged commit 5455b8c into jgm:master Aug 11, 2022
@Witiko
Copy link
Collaborator

Witiko commented Aug 11, 2022

Looks good, thanks again!

@Omikhleia Omikhleia deleted the backport_pipetable_witiko branch February 26, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants