Cast start number of ordered list item to integer in Lua 5.3 #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgm
reviewed
Mar 19, 2019
| @@ -1126,6 +1126,9 @@ function M.new(writer, options) | |||
| local function ordered_list(s,tight,startnum) | |||
| if options.startnum then | |||
| startnum = tonumber(startnum) or 1 -- fallback for '#' | |||
There was a problem hiding this comment.
I am sorry for not double-checking, startnum is startNumber in my fork.
Merged
|
Please note that complete Lua 5.3 support will also require dropping the slnunicode dependency, among other things. I have not yet sunk my teeth into this, but it seems that we can support Lua 5.3 and earlier from one code base using two rockspecs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Lua 5.2, both
print(4)andprint(4.0)writes out4, since both numbers are internally represented as floats. Since version 5.3, Lua differentiates between floats and integers, which affects how casting numbers to strings behaves. Now,print(4)writes out4, whereasprint(4.0)writes out4.0.The code seems to be mostly immune to this change, since we rarely work with numbers, but I discovered one minor regression. Since
larsers.enumeratorcaptures both the number and the period, thetonumberfunction casts the string to a float rather than an integer, affecting the conversion output.