Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default keySize to 2048 and respect in all keys (fixes #33) #35

Closed
wants to merge 1 commit into from

Conversation

blahah
Copy link

@blahah blahah commented Nov 26, 2019

No description provided.

@julien-f
Copy link

@jfromaniello Any chance of seeing this merged?

@blahah
Copy link
Author

blahah commented Mar 3, 2020

Not sure why it is failing but if it would help I can look into it this weekend

@dxdc
Copy link

dxdc commented Mar 25, 2020

@blahah I think the problem is most likely the amount of time allocated for testing. I modified the testing time (see: #36) and included your commit but I guess travis testing doesn't run automatically?

@jfromaniello
Copy link
Owner

Sorry for the long delay, both key size can be changed with an option now.
There is a keySize and clientCertificateKeySize.

The default is still 1024. I will consider changing the default value in a major release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants