Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove trailing slash from GitHub OIDC provider URL #72

Merged
merged 3 commits into from
May 6, 2024
Merged

Remove trailing slash from GitHub OIDC provider URL #72

merged 3 commits into from
May 6, 2024

Conversation

alexhung
Copy link
Member

@alexhung alexhung commented May 6, 2024

Close #71

@alexhung alexhung added the bug Something isn't working label May 6, 2024
@alexhung alexhung marked this pull request as ready for review May 6, 2024 16:33
@alexhung alexhung requested a review from danielmkn as a code owner May 6, 2024 16:33
@alexhung alexhung merged commit 5010949 into main May 6, 2024
5 of 6 checks passed
@alexhung alexhung deleted the GH-71-fix-trailing-slash-from-oidc-provider-url branch May 6, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielmkn danielmkn danielmkn approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent Provider URL for GitHub OIDC Integration
2 participants
@alexhung @danielmkn