Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolves #620 by adding maven sync command #690

Merged
merged 1 commit into from
Jun 15, 2020

Conversation

kowalczykp
Copy link
Contributor

@kowalczykp kowalczykp commented May 12, 2020

  • I signed JFrog's CLA.
  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

This adds maven sync command to the cli, which was added in the jfrog/jfrog-client-go#154

invocation: jfrog-cli bt ms subject/repository/package/version

help:

Name:
  jfrog bt maven-central-sync - Sync Version Artifacts to Maven Central

Usage:
  jfrog bt mcs [command options] <target path>

Arguments:
  target path
    The path, in Bintray, to the version that should be synced.
    Format: subject/repository/package/version.

Options:
  --user                 [Optional] Bintray username. If not set, the subject sent as part of the command argument is used for authentication.
  --key                  [Mandatory] Bintray API key
  --sonatype-username    [Optional] Sonatype OSS username
  --sonatype-password    [Optional] Sonatype OSS user password
  --dont-close           [Default: false] By default the staging repository is closed and artifacts are released to Maven Central.

@kowalczykp
Copy link
Contributor Author

@eyalbe4 @Or-Gabay did you get any chance to look at this PR? Im happy to make any required changes to get this accepted

@bootstraponline
Copy link

@eyalb4doc @liron-shalom @barbelity Hey, it'd be great to have the maven sync feature reviewed and merged.

@bootstraponline
Copy link

@eyalb4doc @liron-shalom @barbelity If there's anything I can do to help get this reviewed and merged, let me know.

@kowalczykp kowalczykp force-pushed the add-mavensync-cmd branch from fd0c2ac to ce48fa9 Compare June 9, 2020 14:32
@kowalczykp
Copy link
Contributor Author

@eyalbe4 I've addressed the PR review comments and squashed the changes

@kowalczykp kowalczykp requested a review from eyalbe4 June 10, 2020 10:49
@CLAassistant
Copy link

CLAassistant commented Jun 11, 2020

CLA assistant check
All committers have signed the CLA.

@eyalbe4 eyalbe4 merged commit 8189800 into jfrog:dev Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants