Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Platform Access Token #2193

Merged
merged 9 commits into from
Oct 3, 2023
Merged

Support Platform Access Token #2193

merged 9 commits into from
Oct 3, 2023

Conversation

RobiNino
Copy link
Contributor

@RobiNino RobiNino commented Sep 7, 2023 •
edited
Loading

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

Note the command currently only supports authentication using an Access Token.
Depends on jfrog/jfrog-cli-core#938

@RobiNino RobiNino added safe to test Approve running integration tests on a pull request new feature Automatically generated release notes labels Sep 7, 2023
@RobiNino RobiNino requested review from eyalbe4 and yahavi September 7, 2023 14:52
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 7, 2023
@RobiNino
Merge branch 'dev' of https://github.com/jfrog/jfrog-cli into jf-acce…
94f32a5 
…ss-token

# Conflicts:
#	go.mod
#	go.sum
#	utils/cliutils/commandsflags.go
@RobiNino RobiNino added the safe to test Approve running integration tests on a pull request label Sep 14, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 14, 2023
@RobiNino RobiNino added the safe to test Approve running integration tests on a pull request label Sep 14, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 14, 2023
yahavi
yahavi requested changes Sep 20, 2023
View reviewed changes
access_test.go Outdated Show resolved Hide resolved
access_test.go Show resolved Hide resolved
access_test.go Outdated Show resolved Hide resolved
artifactory/cli.go Show resolved Hide resolved
docs/general/token/help.go Outdated Show resolved Hide resolved
utils/cliutils/commandsflags.go Show resolved Hide resolved
@eyalbe4 eyalbe4 removed their request for review September 27, 2023 11:37
@RobiNino RobiNino added the safe to test Approve running integration tests on a pull request label Oct 2, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 2, 2023
@RobiNino RobiNino added the safe to test Approve running integration tests on a pull request label Oct 3, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 3, 2023
@RobiNino RobiNino merged commit df7dd63 into jfrog:dev Oct 3, 2023
10 of 11 checks passed
@ZhongRuoyu ZhongRuoyu mentioned this pull request Oct 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yahavi yahavi yahavi requested changes

Assignees
No one assigned
Labels
new feature Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobiNino @yahavi