Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for requesting Curation waivers to the CLI #280

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

igorz-jf
Copy link
Contributor

@igorz-jf igorz-jf commented Jan 6, 2025

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • Updated the Contributing page / ReadMe page / CI Workflow files if needed.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

Adds support for requesting Curation waivers from the CLI, bypassing a blocking policy. This feature depends on the system admin allowing waiver requests. The flow augments the curation audit command, and is effective only for interactive shells.

No effect if waivers are not allowed, or the terminal is in a non-interactive mode.

Copy link
Contributor

@attiasas attiasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please:

  1. expend the description in the PR, what is that waiver? can you attach some ScreenShot or snippet of the changes that the user will be faced.
  2. Make sure your PM went over the Text and approve it.
  3. Please change the documentation if needed

commands/curation/curationaudit.go Outdated Show resolved Hide resolved
commands/curation/curationaudit.go Outdated Show resolved Hide resolved
commands/curation/curationaudit.go Outdated Show resolved Hide resolved
commands/curation/curationaudit.go Outdated Show resolved Hide resolved
commands/curation/curationaudit.go Outdated Show resolved Hide resolved
commands/curation/curationaudit.go Outdated Show resolved Hide resolved
commands/curation/curationaudit.go Show resolved Hide resolved
commands/curation/curationaudit.go Show resolved Hide resolved
commands/curation/curationaudit.go Outdated Show resolved Hide resolved
commands/curation/curationaudit.go Outdated Show resolved Hide resolved
@igorz-jf
Copy link
Contributor Author

@attiasas , I've updated the PR. Also opened a PR for the documentation here.

@igorz-jf igorz-jf requested a review from attiasas January 20, 2025 12:39
@attiasas attiasas added improvement Automatically generated release notes safe to test Approve running integration tests on a pull request labels Jan 22, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 22, 2025
Copy link

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/jfrog/jfrog-cli-security/commands/curation 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/jfrog/jfrog-cli-security/commands/curation/curationaudit.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/jfrog/jfrog-cli-security/commands/curation/curationaudit_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants