Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scan - Add Xray version to Xray graph scan params #253

Merged
merged 3 commits into from
Nov 29, 2024

Conversation

orz25
Copy link
Contributor

@orz25 orz25 commented Nov 29, 2024

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • Updated the Contributing page / ReadMe page / CI Workflow files if needed.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

In addition, XSC tests stopped running, fixing them

@orz25 orz25 added improvement Automatically generated release notes safe to test Approve running integration tests on a pull request labels Nov 29, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 29, 2024
@orz25 orz25 added the safe to test Approve running integration tests on a pull request label Nov 29, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 29, 2024
@orz25 orz25 added the safe to test Approve running integration tests on a pull request label Nov 29, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 29, 2024
Copy link

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/jfrog/jfrog-cli-security 0.00% (ø)
github.com/jfrog/jfrog-cli-security/commands/scan 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/jfrog/jfrog-cli-security/commands/scan/scan.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/jfrog/jfrog-cli-security/audit_test.go
  • github.com/jfrog/jfrog-cli-security/xsc_test.go

@attiasas attiasas added bug Something isn't working and removed improvement Automatically generated release notes labels Nov 29, 2024
@attiasas attiasas changed the title Add xray version to xray graph scan params Scan - Add Xray version to Xray graph scan params Nov 29, 2024
@attiasas attiasas merged commit 4be861f into jfrog:dev Nov 29, 2024
58 of 62 checks passed
@attiasas attiasas mentioned this pull request Dec 1, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants