Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SCA scan issue with XSC and no analytics #252

Merged
merged 3 commits into from
Nov 28, 2024

Conversation

attiasas
Copy link
Contributor

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • Updated the Contributing page / ReadMe page / CI Workflow files if needed.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

Depends on:

@attiasas attiasas added bug Something isn't working safe to test Approve running integration tests on a pull request labels Nov 28, 2024
@attiasas attiasas requested a review from orz25 November 28, 2024 09:49
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 28, 2024
@attiasas attiasas changed the title No MSI No XSC Fix SCA scan issue with XSC when usage is disabled Nov 28, 2024
@attiasas attiasas changed the title Fix SCA scan issue with XSC when usage is disabled Fix SCA scan issue with XSC and no analytics Nov 28, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Nov 28, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 28, 2024
Copy link

👍 Frogbot scanned this pull request and did not find any new security issues.


Copy link

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/jfrog/jfrog-cli-security/utils/xray/scangraph 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/jfrog/jfrog-cli-security/utils/xray/scangraph/scangraph.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@attiasas attiasas merged commit de3a3b9 into jfrog:dev Nov 28, 2024
50 of 53 checks passed
@attiasas attiasas deleted the xsc_no_udage branch November 28, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants