Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License Violation - Show IssueId If LicenseKey is Empty #238

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

attiasas
Copy link
Contributor

@attiasas attiasas commented Nov 18, 2024

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • Updated the Contributing page / ReadMe page / CI Workflow files if needed.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

Some License Violations licenseKey attribute has empty value resulting in empty values displayed:
image

  • Fix this by using IssueId if empty
    image

@attiasas attiasas added bug Something isn't working safe to test Approve running integration tests on a pull request labels Nov 18, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 18, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Nov 18, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 18, 2024
Copy link

👍 Frogbot scanned this pull request and did not find any new security issues.


@attiasas attiasas merged commit 714e273 into jfrog:dev Nov 27, 2024
74 of 97 checks passed
@attiasas attiasas deleted the lic_vio_show_issue_id_if_lic_empty branch November 27, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants