Transfer - Snapshot may be incomplete #1016
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request guarantees that when adding a directory to the repository snapshot, it will happen in real-time, not deferred as a separate task. This is crucial for the following reason:
Imagine the following directory structure:
Before this modification, we might upload the file and then mark "Root" as "DONE" because we've uploaded all files in Root, and the snapshot manager believes there are no children of "Root."
With this change, it ensures that "dir1" will be included in the snapshot before file1 is uploaded. This guarantees that "Root" won't be designated as completed until "dir1" is also completed.
This pull request introduces two more changes: