Evidence CLI - update fields names #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit bf36c53.
lesnerd
reviewed
Aug 6, 2024
| var execFunc = func(command commands.Command) error { | ||
| return commands.Exec(command) | ||
| } | ||
| var execFunc = commands.Exec | ||
|
|
||
| func createEvidence(c *components.Context) error { |
|
|
||
| func (erc *evidenceReleaseBundleCommand) validateEvidenceReleaseBundleContext(ctx *components.Context) error { | ||
| if !ctx.IsFlagSet(releaseBundleVersion) || assertValueProvided(ctx, releaseBundleVersion) != nil { | ||
| return errorutils.CheckErrorf("'releaseBundleVersion' is a mandatory field for creating a Release Bundle evidence: --%s", releaseBundleVersion) |
There was a problem hiding this comment.
Shouldn't we explicitly say Release Bundle v2?
There was a problem hiding this comment.
evidence working with RBV2 only, RBV1 is something going to be sunset for customers.
| } | ||
|
|
||
| func validateCreateEvidenceContext(c *components.Context) error { | ||
| func validateCreateEvidenceCommonContext(c *components.Context) error { |
There was a problem hiding this comment.
Multiple places in this file
| repoPath = "repo-path" | ||
| key = "key" | ||
| keyId = "key-name" | ||
| evidencePrefix = "evd-" |
There was a problem hiding this comment.
ok deleting it, I saw him not in use also before I touched cli.
deleted, done
| predicate: components.NewStringFlag(predicate, "Path to the predicate, arbitrary JSON.", func(f *components.StringFlag) { f.Mandatory = true }), | ||
| predicateType: components.NewStringFlag(predicateType, "Type of the predicate.", func(f *components.StringFlag) { f.Mandatory = true }), | ||
| subjectRepoPath: components.NewStringFlag(subjectRepoPath, "Full path to some subject' location.", func(f *components.StringFlag) { f.Mandatory = false }), | ||
| subjectSha256: components.NewStringFlag(subjectSha256, "subject checksum sha256.", func(f *components.StringFlag) { f.Mandatory = false }), |
There was a problem hiding this comment.
Here start with Upper case 'Subject'
There was a problem hiding this comment.
Why do we need the exec function here?
There was a problem hiding this comment.
we use it for testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.