Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve handling of spaces in command execution utility on Windows #757

Merged
merged 9 commits into from
Sep 20, 2023
Merged

Improve handling of spaces in command execution utility on Windows #757

merged 9 commits into from
Sep 20, 2023

Conversation

talarian1
Copy link
Contributor

  • All tests passed. If this feature is not already covered by the tests, I added new tests.

@talarian1 talarian1 changed the title Fix command execution utility on Windows - better handle spaces Fix command execution utility on Windows - better spaces handle Sep 18, 2023
@talarian1 talarian1 requested a review from asafgabai September 18, 2023 14:38
@talarian1 talarian1 added bug Create a report to help us improve safe to test Approve running integration tests on a pull request labels Sep 18, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 18, 2023
@talarian1 talarian1 force-pushed the fix-command-execution branch from c933623 to d3fc5e2 Compare September 18, 2023 14:43
@talarian1 talarian1 added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels Sep 18, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 18, 2023
@talarian1 talarian1 added the safe to test Approve running integration tests on a pull request label Sep 18, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 18, 2023
@talarian1 talarian1 force-pushed the fix-command-execution branch from bfef01a to 712f15f Compare September 18, 2023 15:15
@talarian1 talarian1 added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels Sep 18, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 18, 2023
@talarian1 talarian1 force-pushed the fix-command-execution branch from 712f15f to 2af4542 Compare September 18, 2023 15:26
@talarian1 talarian1 added the safe to test Approve running integration tests on a pull request label Sep 18, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 18, 2023
@talarian1 talarian1 added the safe to test Approve running integration tests on a pull request label Sep 18, 2023
@talarian1 talarian1 added the safe to test Approve running integration tests on a pull request label Sep 19, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 19, 2023
@talarian1 talarian1 added the safe to test Approve running integration tests on a pull request label Sep 19, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 19, 2023
@talarian1 talarian1 added the safe to test Approve running integration tests on a pull request label Sep 19, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 19, 2023
@talarian1 talarian1 force-pushed the fix-command-execution branch from 7de29ba to c42eeaa Compare September 19, 2023 13:56
@talarian1 talarian1 added the safe to test Approve running integration tests on a pull request label Sep 19, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 19, 2023
@talarian1 talarian1 added the safe to test Approve running integration tests on a pull request label Sep 19, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 19, 2023
@talarian1 talarian1 added the safe to test Approve running integration tests on a pull request label Sep 19, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 19, 2023
@talarian1 talarian1 added the safe to test Approve running integration tests on a pull request label Sep 19, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 19, 2023
@talarian1 talarian1 changed the title Fix command execution utility on Windows - better spaces handle Improve handling of spaces in command execution utility on Windows Sep 20, 2023
@talarian1 talarian1 merged commit 8e57eaf into jfrog:master Sep 20, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asafgabai asafgabai asafgabai requested changes

Assignees
No one assigned
Labels
bug Create a report to help us improve
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@talarian1 @asafgabai