Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow skip VCS stamping in Go #689

Merged
merged 1 commit into from
Dec 29, 2022
Merged

Allow skip VCS stamping in Go #689

merged 1 commit into from
Dec 29, 2022

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Dec 27, 2022 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.

Dependency for: jfrog/ide-plugins-common#93

This fix is for the JFrog IDEA plugin and potentially for the Go build-info extractor -
Allow providing the dontBuildVcs flag, which can be used to skip VCS stamping to bypass the following error:

IOException: error obtaining VCS status: exit status 128 Use -buildvcs=false to disable VCS stamping. error obtaining VCS status: exit status 128 Use -buildvcs=false to disable VCS stamping.

@yahavi yahavi self-assigned this Dec 27, 2022
@yahavi yahavi mentioned this pull request Dec 27, 2022
Merged
1 task
@yahavi yahavi merged commit 8ae1132 into jfrog:master Dec 29, 2022
@yahavi yahavi deleted the go-skip-vcs branch December 29, 2022 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 approved these changes

@attiasas attiasas Awaiting requested review from attiasas

@asafgabai asafgabai Awaiting requested review from asafgabai

Assignees

@yahavi yahavi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yahavi @eyalbe4