Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Docker module ID with slash #666

Merged
merged 2 commits into from
Sep 14, 2022
Merged

Support Docker module ID with slash #666

merged 2 commits into from
Sep 14, 2022

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Sep 13, 2022

  • All tests passed. If this feature is not already covered by the tests, I added new tests.

Fix #665

The module ID of a Docker image with / should include the /.

@yahavi yahavi requested review from eyalbe4 and Or-Geva September 13, 2022 13:34
@yahavi yahavi self-assigned this Sep 13, 2022
@yahavi yahavi mentioned this pull request Sep 13, 2022
Closed
@yahavi yahavi merged commit d984d4a into jfrog:master Sep 14, 2022
@yahavi yahavi deleted the docker-module-2 branch September 14, 2022 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Or-Geva Or-Geva Or-Geva approved these changes

@eyalbe4 eyalbe4 Awaiting requested review from eyalbe4

Assignees

@yahavi yahavi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docker image Module Id is incorrect
2 participants
@yahavi @Or-Geva