Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify artifact type limit and add project support for maven #612

Merged
merged 3 commits into from
Feb 13, 2022
Merged

Verify artifact type limit and add project support for maven #612

merged 3 commits into from
Feb 13, 2022

Conversation

sverdlov93
Copy link
Contributor

@sverdlov93 sverdlov93 commented Feb 2, 2022 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.

Verify that the artifact type is less than 64 characters.
If it's longer, don't use classifier or extension as type.

Fixing jfrog/artifactory-maven-plugin#29

@sverdlov93 sverdlov93 requested a review from eyalbe4 February 2, 2022 20:36
@sverdlov93 sverdlov93 changed the title Verify artifact type length limit Verify artifact type limit and add project support for maven Feb 3, 2022
@sverdlov93 sverdlov93 mentioned this pull request Feb 3, 2022
Merged
1 task
@sverdlov93 sverdlov93 merged commit c6f40b0 into master Feb 13, 2022
@sverdlov93 sverdlov93 deleted the verify-artifact-type-limit branch February 17, 2022 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sverdlov93 @eyalbe4