Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multi lines NuGet project definition #96

Merged
merged 3 commits into from
Aug 25, 2022
Merged

Conversation

talarian1
Copy link
Contributor

@talarian1 talarian1 commented Aug 24, 2022

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

This PR fixes the wrong handling of multi lines project definitions inside .sln files. The following definition was missed by the old regex expression :

Project("{...}") = "Core", "Core\Core.csproj", "{...}"
	ProjectSection(ProjectDependencies) = postProject
		{...}= {...}
	EndProjectSection
EndProject

Which caused incomplete build info creation.

@talarian1 talarian1 added the bug Something isn't working label Aug 24, 2022
@talarian1 talarian1 requested a review from eyalbe4 August 24, 2022 17:21
@talarian1 talarian1 requested a review from eyalbe4 August 25, 2022 09:12
@talarian1 talarian1 merged commit 33bd565 into jfrog:dev Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants