Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pip dependencies script for python 3.11 & add python versions tests #117

Merged
merged 3 commits into from
Nov 13, 2022
Merged

Fix pip dependencies script for python 3.11 & add python versions tests #117

merged 3 commits into from
Nov 13, 2022

Conversation

sverdlov93
Copy link
Contributor

Signed-off-by: Michael Sverdlov [email protected]

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

@sverdlov93
install latest pipdeptree
09e812f 
Signed-off-by: Michael Sverdlov <[email protected]>
@sverdlov93
install latest pipdeptree
564a689 
Signed-off-by: Michael Sverdlov <[email protected]>
@sverdlov93 sverdlov93 requested a review from eyalbe4 November 10, 2022 17:56
@sverdlov93 sverdlov93 changed the title Fix python dependencies script for python 3.11 Fix pip dependencies script for python 3.11 Nov 10, 2022
@sverdlov93 sverdlov93 changed the title Fix pip dependencies script for python 3.11 Fix pip dependencies script for python 3.11 & add python versions tests Nov 13, 2022
@sverdlov93 sverdlov93 requested a review from yahavi November 13, 2022 09:56
@sverdlov93 sverdlov93 added the improvement Automatically generated release notes label Nov 13, 2022
eyalbe4
eyalbe4 approved these changes Nov 13, 2022
View reviewed changes
.github/workflows/test.yml Outdated Show resolved Hide resolved
@sverdlov93
install latest pipdeptree
b7c4e1e 
Signed-off-by: Michael Sverdlov <[email protected]>
@sverdlov93 sverdlov93 merged commit b9b8798 into dev Nov 13, 2022
@sverdlov93 sverdlov93 deleted the fix-pipdeptree-3.11 branch November 13, 2022 12:36
@eyalbe4 eyalbe4 added bug Something isn't working and removed improvement Automatically generated release notes labels Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 approved these changes

@yahavi yahavi Awaiting requested review from yahavi

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sverdlov93 @eyalbe4