Run remote tests locally more often #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jfmengels, this should fix your issue from #325 (comment). |
|
Uhhh... this flake is concerning. Read through it. I have no idea how that code path might be triggered, but I can repro locally, which is a step in the right direction. |
zx suppresses output by default (but still throws an error).
Haste is an ancient, deprecated, and unmaintained module system, which happens to power Jest. It doesn't like that there are duplicate manifests in the temp and snapshot dirs.
|
Oh, jest messing with stuff (pun intended). |
lishaduck
force-pushed
the
fix-remote
branch
from
73cc247 to
962911a
Compare
I'm somewhat concerned that this didn't consistently fail. This should fix CI.
|
@jfmengels, this doesn't finish fixing #313, but it does fix enough I think it's worth merging and following up. |
|
@jfmengels, ping |
|
Sorry for the delay. Thank your for the improvements, they look nice 👍 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression from #325.