-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump deps #256
Bump deps #256
Conversation
@jfmengels, can you take a look? I think all of the snapshot changes are correct, but I just skimmed 'em. The json was particularly intimidating. EDIT: Also, the TS errors should've already been broken; I guess TS 5.6 fixed a related bug? They officially block this on a release of rtfeldman/node-test-runner#636. |
Fixes snapshots by bumping: - jfmengels/elm-review => 2.14.1 - misc in the config-unparsable-elmjson snapshot
@jfmengels, ping. I think all of the remaining test failures are snapshots that broke when you added fixes or contained version numbers. |
Figured out why there were a bunch of behavioral changes: |
To make this reviewable, I removed `NoUnused.Modules`, as the new `NoUnused.Exports` duplicated it. Also, `NoUnused.CustomTypeConstructors` got a fix, which changed a lot.
@@ -49,7 +49,7 @@ | |||
"elm-tests": "(cd template/ && elm make src/Elm/Review/Main.elm --output=/dev/null && elm-test)", | |||
"eslint-check": "eslint . --report-unused-disable-directives --max-warnings=0", | |||
"eslint-fix": "npm run eslint-check -- --fix", | |||
"jest": "npx jest", | |||
"jest": "jest", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong commit, but doesn't make any behavioral change beyond shaving a few milliseconds off testing.
@lishaduck Thank you for all your work! And I'm so sorry for not tending to your pull requests 😞 |
Give me a minute before merging #264, I'm working on it literally right now. |
Follow up to #255, bumps everything else.
I also had this commit, but npm dedupe reverted it, so I did too:
Ref: rtfeldman/node-test-runner#636