Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump deps #256

Merged
merged 12 commits into from
Oct 28, 2024
Merged

Bump deps #256

merged 12 commits into from
Oct 28, 2024

Conversation

lishaduck
Copy link
Contributor

Follow up to #255, bumps everything else.


I also had this commit, but npm dedupe reverted it, so I did too:

chore(deps): bump elm-solve-deps-wasm

Manually edited the `package-lock.json` to force `elm-solve-deps-wasm` v2.
Then, regenerated the lockfile to give `elm-test` the old version.
Workaround for rtfeldman/node-test-runner#636.

Ref: rtfeldman/node-test-runner#636

Copy link

socket-security bot commented Sep 25, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@eslint-community/[email protected] None +2 98 kB eslint-community-bot
npm/@types/[email protected] Transitive: environment, unsafe +42 1.63 MB types
npm/[email protected] filesystem Transitive: environment, eval, network, shell, unsafe +123 3.96 MB rlefevre
npm/[email protected] Transitive: environment, filesystem +2 479 kB turbobot
npm/[email protected] None 0 72.5 kB eslint-community-bot
npm/[email protected] environment, filesystem Transitive: eval, unsafe +80 10.5 MB eslintbot
npm/[email protected] Transitive: environment, filesystem, shell +20 2.6 MB isaacs
npm/[email protected] filesystem Transitive: environment +14 810 kB satya164
npm/[email protected] Transitive: environment, eval, filesystem, network, shell, unsafe +245 19.7 MB simenb
npm/[email protected] Transitive: environment, eval, filesystem, network, shell, unsafe +277 15 MB ljharb
npm/[email protected] environment Transitive: eval, filesystem, shell +100 4.43 MB mysticatea
npm/[email protected] environment, filesystem 0 281 kB isaacs
npm/[email protected] None +3 149 kB sindresorhus
npm/[email protected] None +6 164 MB jaredpalmer, turbobot, vercel-release-bot
npm/[email protected] None 0 22.4 MB typescript-bot
npm/[email protected] environment Transitive: filesystem +1 20.9 kB isaacs
npm/[email protected] None +3 69.1 kB sindresorhus

🚮 Removed packages: npm/@eslint-community/[email protected], npm/@types/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

@lishaduck
Copy link
Contributor Author

lishaduck commented Sep 25, 2024

@jfmengels, can you take a look? I think all of the snapshot changes are correct, but I just skimmed 'em. The json was particularly intimidating.

EDIT: Also, the TS errors should've already been broken; I guess TS 5.6 fixed a related bug? They officially block this on a release of rtfeldman/node-test-runner#636.

Fixes snapshots by bumping:
- jfmengels/elm-review => 2.14.1
- misc in the config-unparsable-elmjson snapshot
@lishaduck
Copy link
Contributor Author

lishaduck commented Oct 14, 2024

@jfmengels, ping.
I worked around rtfeldman/node-test-runner#636 and then updated snapshots again.

I think all of the remaining test failures are snapshots that broke when you added fixes or contained version numbers.

@lishaduck
Copy link
Contributor Author

I think all of the remaining test failures are snapshots that broke when you added fixes or contained version numbers. [emphasis added]

Figured out why there were a bunch of behavioral changes: NoUnused.Modules got folded into NoUnused.Exports, which made the diff significantly larger. Removing NoUnused.Modules made it much more reviewable.

To make this reviewable, I removed `NoUnused.Modules`, as the new `NoUnused.Exports` duplicated it.
Also, `NoUnused.CustomTypeConstructors` got a fix, which changed a lot.
@@ -49,7 +49,7 @@
"elm-tests": "(cd template/ && elm make src/Elm/Review/Main.elm --output=/dev/null && elm-test)",
"eslint-check": "eslint . --report-unused-disable-directives --max-warnings=0",
"eslint-fix": "npm run eslint-check -- --fix",
"jest": "npx jest",
"jest": "jest",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong commit, but doesn't make any behavioral change beyond shaving a few milliseconds off testing.

@jfmengels
Copy link
Owner

@lishaduck Thank you for all your work! And I'm so sorry for not tending to your pull requests 😞
I'll try to look at the rest of the PRs quickly.

@lishaduck
Copy link
Contributor Author

@lishaduck Thank you for all your work! And I'm so sorry for not tending to your pull requests 😞 I'll try to look at the rest of the PRs quickly.

Give me a minute before merging #264, I'm working on it literally right now.

@lishaduck lishaduck mentioned this pull request Oct 31, 2024
@lishaduck lishaduck deleted the fix-ci-bump-deps branch November 4, 2024 02:30
@lishaduck lishaduck mentioned this pull request Nov 5, 2024
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants