Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSDoc Updates #165

Merged
merged 12 commits into from
Jun 22, 2024
Merged

JSDoc Updates #165

merged 12 commits into from
Jun 22, 2024

Conversation

lishaduck
Copy link
Contributor

Sort, format, lint jsdocs.

Depends on #164

Here's the diff as GH doesn't play well with stacks from forks: lishaduck/node-elm-review@turbo...jsdocs

Copy link

socket-security bot commented Jun 22, 2024

I'm not adding it because @imports support needs Node 18.
@lishaduck lishaduck changed the title JSDoc JSDoc Updates Jun 22, 2024
@lishaduck lishaduck mentioned this pull request Jun 22, 2024
@@ -7,8 +7,8 @@ machines, and also the same output when only the CLI version changes.
const path = require('path');

/**
* @typedef { import("./types/options").Options } Options
* @typedef { import("./types/path").Path } Path
* @import {Options} from "./types/options"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay for TS 5.5 🎉

@jfmengels jfmengels merged commit 0708332 into jfmengels:main Jun 22, 2024
2 of 3 checks passed
@jfmengels
Copy link
Owner

jfmengels commented Jun 22, 2024

Thanks again ☺️
There was a TS error that was introduced here but I pushed a fix.

@lishaduck
Copy link
Contributor Author

Thanks again ☺️ There was a TS error that was introduced here but I pushed a fix.

Thanks! I did a bunch of rebasing and must've missed one.

@jfmengels
Copy link
Owner

jfmengels commented Jun 22, 2024

Yeah, I later noticed you fixed the issue in the typings PR. That's fine, no worries 👍

@lishaduck lishaduck deleted the jsdocs branch June 22, 2024 16:12
@lishaduck lishaduck mentioned this pull request Jun 28, 2024
@lishaduck lishaduck mentioned this pull request Aug 15, 2024
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants