Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update generated array style #1111

Merged
merged 1 commit into from
Jan 1, 2025
Merged

Update generated array style #1111

merged 1 commit into from
Jan 1, 2025

Conversation

kluever
Copy link
Contributor

@kluever kluever commented Dec 29, 2024

C-style array declarations (e.g. Foo foos[]) is discouraged by the JLS. Java style (e.g., Foo[] foos) should be preferred.

C-style array declarations (e.g. `Foo foos[]`) is discouraged by the JLS. Java style (e.g., `Foo[] foos`) should be preferred.
@kluever kluever requested a review from lsf37 as a code owner December 29, 2024 15:05
@ice1000
Copy link

ice1000 commented Dec 31, 2024

The issue number is 1111! Cool!

@lsf37
Copy link
Member

lsf37 commented Jan 1, 2025

Thanks, that will probably quiet down some linters.

@lsf37 lsf37 merged commit b820ca9 into jflex-de:master Jan 1, 2025
22 checks passed
@lsf37 lsf37 added the code quality Code health and clean-up label Jan 1, 2025
github-actions bot pushed a commit that referenced this pull request Jan 1, 2025
commit b820ca9
Author:     Kurt Alfred Kluever <[email protected]>
AuthorDate: Wed Jan 1 17:24:42 2025 -0500
Commit:     GitHub <[email protected]>
CommitDate: Thu Jan 2 09:24:42 2025 +1100

    Update generated array style (#1111)

    C-style array declarations (e.g. `Foo foos[]`) is discouraged by the JLS. Java style (e.g., `Foo[] foos`) should be preferred.

Updated from
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Code health and clean-up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants