Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace single_file by allow_single_file #13

Merged
merged 2 commits into from
Nov 2, 2019
Merged

Replace single_file by allow_single_file #13

merged 2 commits into from
Nov 2, 2019

Conversation

regisd
Copy link
Member

@regisd regisd commented Nov 2, 2019

Fix #12

@regisd regisd added this to the v4 milestone Nov 2, 2019
@regisd regisd self-assigned this Nov 2, 2019
@regisd
Replace http:// by https:// for third_party resources.
2d27ba3 
ERROR: /tmp/cirrus-ci-build/third_party/com/google/guava/BUILD:7:1: //third_party/com/google/guava:guava depends on @com_google_guava_guava_26_0_jre//jar:jar in repository @com_google_guava_guava_26_0_jre which failed to fetch. no such package '@com_google_guava_guava_26_0_jre//jar': Plain HTTP URLs are not allowed without checksums in the maven_jar rule. Please use HTTPS for the maven_server rule for http://jcenter.bintray.com/ or add a sha1 checksum to the maven_jar rule. To disable this check, pass --incompatible_disallow_unverified_http_downloads=false to your build
ERROR: Analysis of target '//third_party/com/google/guava:guava' failed; build aborted: Analysis failed
@regisd regisd merged commit 66116c2 into jflex-de:master Nov 2, 2019
@regisd regisd added the bug Something isn't working label Nov 2, 2019
@regisd regisd mentioned this pull request Nov 5, 2019
Merged
regisd added a commit to jflex-de/jflex that referenced this pull request Nov 5, 2019
@regisd
Fix the build (#569)
8e95060 
* Fix #570. Build broken on Cirrus by upgrade to Bazel v1.0
  * The `single_file` attribute has been replaced by `allow_single_file`.
    Use **bazel_rules** v4 which fixed this. jflex-de/bazel_rules#13
  * add `--incompatible_depset_union=false`
    bazel_pandoc ProdriveTechnologies/bazel-pandoc#6 needs to update for incompatible_depset_union bazelbuild/bazel#5817
  * Use ProdriveTechnologies/bazel-latex#26 because `run_lualatex.py` is not executable
  * In deps, use `https` rather than `http`
* Fix build broken on Travis due to upgrade to Xenial
  * Use openjdk11 because whatever I ask for, that's what I get.
  * Upgrade maven-compiler-plugin to 3.8.0 to fix _class file has wrong version 55.0, should be 53.0_
  * Fix maven-compiler-plugin config for ErrorProne
  * Fix config of maven-javadoc-plugin for newer JDK. https://bugs.openjdk.java.net/browse/JDK-8212233
  * In aggregated sources, update to JDK8 because Xenial doesn't support JDK7 anymore.
    Add manual dep on **javax-annotations.jar** because because JDK8 doesn't provide it anymore.
  * Remove the task that builds the docs because `\tightlist` is not known. #571
regisd pushed a commit to jflex-de/jflex that referenced this pull request Nov 5, 2019
@traviscibot
Pseudo-Merge commit 8e95060
13c1e50 
Author: Régis Décamps <[email protected]>
Date:   Tue Nov 5 11:16:01 2019 +0100

    Fix the build (#569)

    * Fix #570. Build broken on Cirrus by upgrade to Bazel v1.0
      * The `single_file` attribute has been replaced by `allow_single_file`.
        Use **bazel_rules** v4 which fixed this. jflex-de/bazel_rules#13
      * add `--incompatible_depset_union=false`
        bazel_pandoc ProdriveTechnologies/bazel-pandoc#6 needs to update for incompatible_depset_union bazelbuild/bazel#5817
      * Use ProdriveTechnologies/bazel-latex#26 because `run_lualatex.py` is not executable
      * In deps, use `https` rather than `http`
    * Fix build broken on Travis due to upgrade to Xenial
      * Use openjdk11 because whatever I ask for, that's what I get.
      * Upgrade maven-compiler-plugin to 3.8.0 to fix _class file has wrong version 55.0, should be 53.0_
      * Fix maven-compiler-plugin config for ErrorProne
      * Fix config of maven-javadoc-plugin for newer JDK. https://bugs.openjdk.java.net/browse/JDK-8212233
      * In aggregated sources, update to JDK8 because Xenial doesn't support JDK7 anymore.
        Add manual dep on **javax-annotations.jar** because because JDK8 doesn't provide it anymore.
      * Remove the task that builds the docs because `\tightlist` is not known. #571

Updated from target/jflex-parent-1.8.0-SNAPSHOT-sources.jar
@regisd regisd deleted the bazel-flag-single-file branch November 19, 2019 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@regisd regisd

Labels
bug Something isn't working
Projects
None yet
Milestone
v4
Development

Successfully merging this pull request may close these issues.

'single_file' is no longer supported
1 participant
@regisd