Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix screen capture on screens with 24 bit depth and 32 bpp #6

Merged
merged 2 commits into from
Aug 4, 2024

Conversation

alex3d
Copy link

@alex3d alex3d commented Jul 22, 2024

Currently on 24 bit depth and 32 bpp screens (e.g. ubuntu 24.04 with intel integrated graphics) screen capture produces image with right dimensions but with solid gray color fill. This happens because readDrawableData reads all pixels as fully transparent with alpha=0.

BurntSushi#36

Copy link
Owner

@jezek jezek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

I haven't tested this myself, but all the changes are logical and seem legit to me. I trust you you tested it well.

Could you make the changes I requested (and test it again with them), please? After, I think, it'll be ready for merge.

@alex3d alex3d requested a review from jezek August 2, 2024 20:44
@jezek jezek merged commit e2e9464 into jezek:master Aug 4, 2024
@jezek
Copy link
Owner

jezek commented Aug 4, 2024

@alex3d Thank you for your contribution. I've tested it, it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants