Add TRANSFER_ENCODING violation for MultiPart RFC7578 parser. #7976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachlan Roberts <[email protected]>
joakime
reviewed
May 11, 2022
| @@ -610,7 +637,8 @@ else if (key.equalsIgnoreCase("content-type")) | |||
|
|
|||
| // Transfer encoding is not longer considers as it is deprecated as per | |||
| // https://tools.ietf.org/html/rfc7578#section-4.7 | |||
|
|
|||
| if (key.equalsIgnoreCase("content-transfer-encoding")) | |||
There was a problem hiding this comment.
Do we want to be more subtle about this?
There are 3 Content-Transfer-Encoding scenarios that are not a violation (as they basically mean nothing more than "identity" or "no encoding")
Content-Transfer-Encoding: 8bit(common enough in older httpclients)Content-Transfer-Encoding: binary(also common enough, Apache HttpClient will use this for example)Content-Transfer-Encoding: 7bit(this one is iffy)
So that any other value is a violation
Signed-off-by: Lachlan Roberts <[email protected]>
joakime
approved these changes
May 11, 2022
lachlan-roberts
added a commit
that referenced
this pull request
May 12, 2022
* Add TRANSFER_ENCODING violation for MultiPart RFC7578 parser. * Ignore TRANSFER_ENCODING violation for 8bit and binary. Signed-off-by: Lachlan Roberts <[email protected]>
lachlan-roberts
added a commit
that referenced
this pull request
May 16, 2022
Add TRANSFER_ENCODING violation for MultiPart RFC7578 parser. (#7976)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://datatracker.ietf.org/doc/html/rfc7578#section-4.7