Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #5965 - fixing invalid dot output from start.jar (#7606) #7640

Merged
merged 1 commit into from
Mar 2, 2022
Merged

Issue #5965 - fixing invalid dot output from start.jar (#7606) #7640

merged 1 commit into from
Mar 2, 2022

Conversation

joakime
Copy link
Contributor

@joakime joakime commented Feb 23, 2022

Cherry-pick of commit 1aba450 (from jetty-9.4.x to jetty-10.0.x)

@joakime
Issue #5965 - fixing invalid dot output from start.jar (#7606)
23a1dc5 
* Adding testcase that can use `dot` if it exists on the machine.
@joakime joakime added the Bug For general bugs on Jetty side label Feb 23, 2022
@joakime joakime added this to the 10.0.x milestone Feb 23, 2022
@joakime joakime requested a review from sbordet February 23, 2022 11:12
@joakime joakime self-assigned this Feb 23, 2022
@joakime joakime linked an issue Feb 23, 2022 that may be closed by this pull request
Option --write-module-graph produces wrong .dot file #5965
Closed
@joakime
Copy link
Contributor Author

joakime commented Mar 1, 2022

@sbordet bump, review

@joakime joakime merged commit 32222e4 into jetty-10.0.x Mar 2, 2022
@joakime joakime deleted the jetty-10.0.x-5965-cherrypick-start-dot-fix branch March 2, 2022 12:07
@joakime joakime mentioned this pull request Oct 6, 2022
Closed
51 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbordet sbordet sbordet approved these changes

Assignees

@joakime joakime

Labels
Bug For general bugs on Jetty side
Projects
None yet
Milestone
10.0.x
Development

Successfully merging this pull request may close these issues.

Option --write-module-graph produces wrong .dot file
2 participants
@joakime @sbordet