Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #7567 - don't compare params when checking MIME type for GzipHandler #7576

Merged
merged 2 commits into from
Feb 16, 2022
Merged

Issue #7567 - don't compare params when checking MIME type for GzipHandler #7576

merged 2 commits into from
Feb 16, 2022

Conversation

lachlan-roberts
Copy link
Contributor

@lachlan-roberts lachlan-roberts commented Feb 14, 2022 •
edited
Loading

Issue #7567

  • add testing for GzipHandler with multipart/form-data content types
  • strip params before comparing MIME type with the included/excluded mime types in GzipHandler

joakime
joakime approved these changes Feb 14, 2022
View reviewed changes
Copy link
Contributor

@joakime joakime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks odd (going from MimeTypes.getContentTypeWithoutCharset(ct) to HttpField.valueParameters(ct, null) seems like a step backwards.

But it works, so ship it!

@lachlan-roberts lachlan-roberts mentioned this pull request Feb 16, 2022
Merged
@lachlan-roberts lachlan-roberts merged commit 533f2b1 into jetty-10.0.x Feb 16, 2022
@lachlan-roberts lachlan-roberts deleted the jetty-10.0.x-7567-MultiPartGzip branch February 16, 2022 22:07
@joakime joakime mentioned this pull request Feb 24, 2022
Closed
22 tasks
@joakime joakime added this to the 12.0.x milestone Feb 24, 2022
@joakime joakime linked an issue Feb 24, 2022 that may be closed by this pull request
Gzip compression not working for multipart/form-data when added to the allowed list using addIncludedMimeTypes. #7567
Closed
@joakime joakime mentioned this pull request Oct 6, 2022
Closed
51 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joakime joakime joakime approved these changes

@gregw gregw gregw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
12.0.x
3 participants
@lachlan-roberts @gregw @joakime