Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #7524 - Missing package in JmxConfiguration #7525

Merged
merged 1 commit into from
Feb 3, 2022
Merged

Fixes #7524 - Missing package in JmxConfiguration #7525

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion jetty-webapp/src/main/java/org/eclipse/jetty/webapp/JmxConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ public class JmxConfiguration extends AbstractConfiguration
public JmxConfiguration()
{
addDependents(WebXmlConfiguration.class, MetaInfConfiguration.class, WebInfConfiguration.class);
protectAndExpose("org.eclipse.jetty.jmx.");
protectAndExpose("org.eclipse.jetty.util.annotation", "org.eclipse.jetty.jmx.");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correctly restoring the jetty-9 behaviour, so good to proceed with.

BUT ultimately we should avoid exposing jetty classes like this. So we should consider an option of how we can use Jmx in the server and not expose to the webapp: either by making this line conditional or moving into another alternate optional configuration (which would need it's own jar).

}

@Override
Expand Down