Fixes #7240 - Clarify and javadoc InvocationType. #7241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simone Bordet <[email protected]>
gregw
requested changes
Dec 8, 2021
Comment on lines
69
to
74
| * <p>This invocation type is suitable for {@code Invocable}s that | ||
| * themselves produce other {@code Invocable}s.</p> | ||
| * <p>The invocation of this {@code Invocable} causes the | ||
| * production of other, nested, {@code Invocable}s, which may be | ||
| * of type {@link #NON_BLOCKING} and therefore are invoked | ||
| * immediately, thus advancing a possibly stalled system.</p> |
There was a problem hiding this comment.
I think this is too specific.
It is for tasks that can do useful/important work without blocking, but may block in some sub-tasks if allowed to do so by the invocation.
Updates after review. Signed-off-by: Simone Bordet <[email protected]>
sbordet
force-pushed
the
jetty-10.0.x-7240-clarify-invocationtype-either
branch
from
6f82114 to
b85c169
Compare
gregw
approved these changes
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Simone Bordet [email protected]